helm: add option to set maximum size for file preview #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #732 +/- ##
=======================================
Coverage 18.87% 18.87%
=======================================
Files 26 26
Lines 2199 2199
=======================================
Hits 415 415
Misses 1784 1784 |
mdonadoni
force-pushed
the
preview-size-limit
branch
from
d3a5dcb
to
08dfcb9
Compare
mdonadoni
force-pushed
the
preview-size-limit
branch
from
08dfcb9
to
653d80e
Compare
helm/reana/README.md
Outdated
| @@ -31,6 +31,7 @@ This Helm automatically prefixes all names using the release name to avoid colli | |||
| | `components.reana_server.uwsgi.log_5xx` | Log only error HTTP requests with status code 5xx. To make this configuration effective `components.reana_server.uwsgi.log_all` must be false. | true | | |||
| | `components.reana_ui.announcement` | Announcement message displayed in site top banner | None | | |||
| | `components.reana_ui.enabled` | Instantiate the [REANA-UI](https://github.com/reanahub/reana-ui) | true | | |||
| | `components.reana_ui.file_preview_size_limit` | Maximum file size (in bytes) that can be previewed in the web interface | 5242880 | | |||
There was a problem hiding this comment.
Suggested change
| | `components.reana_ui.file_preview_size_limit` | Maximum file size (in bytes) that can be previewed in the web interface | 5242880 | | |
| | `components.reana_ui.file_preview_size_limit` | Maximum file size (in bytes) that can be previewed in the web interface. Default value: 5242880 = 5 MiB | 5242880 | |
What do you think? To give a friendly explaination of the number used as default value, as is done for kubernetes_jobs_timeout_limit and kubernetes_jobs_max_user_timeout_limit
mdonadoni
force-pushed
the
preview-size-limit
branch
from
653d80e
to
2e6afdf
Compare
giuseppe-steduto
approved these changes
Aug 8, 2023
mdonadoni
force-pushed
the
preview-size-limit
branch
from
2e6afdf
to
bb10e8a
Compare
|
Rebased and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728